Consider to make sure append always copies the input slice

[bep]

Go's append (and reflect.Append) reuses the input slice if there is enough capacity, else it creates a new one and copies the content over.

The reason we have not seen this bug before is probably

1. Because in most common cases where you use append you're working on a local slice and the current behaviour makes sense.
2. append is used on slices returned from where etc.
3. append is called enough elements so the capacity needs to be expanded.

Note that the other collection funcs (where, union etc.) always creates a new slice.

See https://discourse.gohugo.io/t/appending-a-page-to-a-page-collection-append-or-union/41532/10

[bep]

@jmooring I will fixed this pretty fast, but I suspect that you can do:

{{ $pages := slice | append site.RegularPages }}
... now it should be safe to append more to the new slice.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.