Skip to content

Commit

Permalink
Add warnidf template function
Browse files Browse the repository at this point in the history
Also rename config `ignoreErrors` => `ignoreLogs`

But the old still works.

Closes #9189
  • Loading branch information
bep committed Jan 30, 2024
1 parent b00bba2 commit 098a0ce
Show file tree
Hide file tree
Showing 11 changed files with 83 additions and 29 deletions.
15 changes: 13 additions & 2 deletions common/loggers/logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ type Logger interface {
Debugln(v ...any)
Error() logg.LevelLogger
Errorf(format string, v ...any)
Erroridf(id, format string, v ...any)
Errorln(v ...any)
Errors() string
Errorsf(id, format string, v ...any)
Info() logg.LevelLogger
InfoCommand(command string) logg.LevelLogger
Infof(format string, v ...any)
Expand All @@ -197,6 +197,7 @@ type Logger interface {
Warn() logg.LevelLogger
WarnCommand(command string) logg.LevelLogger
Warnf(format string, v ...any)
Warnidf(id, format string, v ...any)
Warnln(v ...any)
Deprecatef(fail bool, format string, v ...any)
Trace(s logg.StringFunc)
Expand Down Expand Up @@ -321,10 +322,20 @@ func (l *logAdapter) Errors() string {
return l.errors.String()
}

func (l *logAdapter) Errorsf(id, format string, v ...any) {
func (l *logAdapter) Erroridf(id, format string, v ...any) {
format += l.idfInfoStatement("error", id, format)
l.errorl.WithField(FieldNameStatementID, id).Logf(format, v...)
}

func (l *logAdapter) Warnidf(id, format string, v ...any) {
format += l.idfInfoStatement("warning", id, format)
l.warnl.WithField(FieldNameStatementID, id).Logf(format, v...)
}

func (l *logAdapter) idfInfoStatement(what, id, format string) string {
return fmt.Sprintf("\nYou can suppress this %s by adding the following to your site configuration:\nignoreLogs = ['%s']", what, id)
}

func (l *logAdapter) Trace(s logg.StringFunc) {
l.tracel.Log(s)
}
Expand Down
16 changes: 8 additions & 8 deletions config/allconfig/allconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func (c Config) cloneForLang() *Config {
x.DisableKinds = copyStringSlice(x.DisableKinds)
x.DisableLanguages = copyStringSlice(x.DisableLanguages)
x.MainSections = copyStringSlice(x.MainSections)
x.IgnoreErrors = copyStringSlice(x.IgnoreErrors)
x.IgnoreLogs = copyStringSlice(x.IgnoreLogs)
x.IgnoreFiles = copyStringSlice(x.IgnoreFiles)
x.Theme = copyStringSlice(x.Theme)

Expand Down Expand Up @@ -299,9 +299,9 @@ func (c *Config) CompileConfig(logger loggers.Logger) error {
}
}

ignoredErrors := make(map[string]bool)
for _, err := range c.IgnoreErrors {
ignoredErrors[strings.ToLower(err)] = true
ignoredLogIDs := make(map[string]bool)
for _, err := range c.IgnoreLogs {
ignoredLogIDs[strings.ToLower(err)] = true
}

baseURL, err := urls.NewBaseURLFromString(c.BaseURL)
Expand Down Expand Up @@ -357,7 +357,7 @@ func (c *Config) CompileConfig(logger loggers.Logger) error {
BaseURLLiveReload: baseURL,
DisabledKinds: disabledKinds,
DisabledLanguages: disabledLangs,
IgnoredErrors: ignoredErrors,
IgnoredLogs: ignoredLogIDs,
KindOutputFormats: kindOutputFormats,
CreateTitle: helpers.GetTitleFunc(c.TitleCaseStyle),
IsUglyURLSection: isUglyURL,
Expand Down Expand Up @@ -394,7 +394,7 @@ type ConfigCompiled struct {
KindOutputFormats map[string]output.Formats
DisabledKinds map[string]bool
DisabledLanguages map[string]bool
IgnoredErrors map[string]bool
IgnoredLogs map[string]bool
CreateTitle func(s string) string
IsUglyURLSection func(section string) bool
IgnoreFile func(filename string) bool
Expand Down Expand Up @@ -501,8 +501,8 @@ type RootConfig struct {
// Enable to disable the build lock file.
NoBuildLock bool

// A list of error IDs to ignore.
IgnoreErrors []string
// A list of log IDs to ignore.
IgnoreLogs []string

// A list of regexps that match paths to ignore.
// Deprecated: Use the settings on module imports.
Expand Down
4 changes: 2 additions & 2 deletions config/allconfig/configlanguage.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ func (c ConfigLanguage) IsLangDisabled(lang string) bool {
return c.config.C.DisabledLanguages[lang]
}

func (c ConfigLanguage) IgnoredErrors() map[string]bool {
return c.config.C.IgnoredErrors
func (c ConfigLanguage) IgnoredLogs() map[string]bool {
return c.config.C.IgnoredLogs
}

func (c ConfigLanguage) NoBuildLock() bool {
Expand Down
1 change: 1 addition & 0 deletions config/allconfig/load.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ func (l configLoader) applyConfigAliases() error {
{Key: "indexes", Value: "taxonomies"},
{Key: "logI18nWarnings", Value: "printI18nWarnings"},
{Key: "logPathWarnings", Value: "printPathWarnings"},
{Key: "ignoreErrors", Value: "ignoreLogs"},
}

for _, alias := range aliases {
Expand Down
2 changes: 1 addition & 1 deletion config/configProvider.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type AllProvider interface {
NewContentEditor() string
Timeout() time.Duration
StaticDirs() []string
IgnoredErrors() map[string]bool
IgnoredLogs() map[string]bool
WorkingDir() string
EnableEmoji() bool
}
Expand Down
20 changes: 18 additions & 2 deletions hugolib/integrationtest_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ func TestOptDebug() TestOpt {
}
}

// TestOptWarn will enable warn logging in integration tests.
func TestOptWarn() TestOpt {
return func(c *IntegrationTestConfig) {
c.LogLevel = logg.LevelWarn
}
}

// TestOptWithNFDOnDarwin will normalize the Unicode filenames to NFD on Darwin.
func TestOptWithNFDOnDarwin() TestOpt {
return func(c *IntegrationTestConfig) {
Expand Down Expand Up @@ -181,9 +188,18 @@ func (b *lockingBuffer) Write(p []byte) (n int, err error) {
return
}

func (s *IntegrationTestBuilder) AssertLogContains(text string) {
func (s *IntegrationTestBuilder) AssertLogContains(els ...string) {
s.Helper()
s.Assert(s.logBuff.String(), qt.Contains, text)
for _, el := range els {
s.Assert(s.logBuff.String(), qt.Contains, el)
}
}

func (s *IntegrationTestBuilder) AssertLogNotContains(els ...string) {
s.Helper()
for _, el := range els {
s.Assert(s.logBuff.String(), qt.Not(qt.Contains), el)
}
}

func (s *IntegrationTestBuilder) AssertLogMatches(expression string) {
Expand Down
2 changes: 1 addition & 1 deletion hugolib/site_new.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func NewHugoSites(cfg deps.DepsCfg) (*HugoSites, error) {
Stdout: cfg.LogOut,
Stderr: cfg.LogOut,
StoreErrors: conf.Running(),
SuppressStatements: conf.IgnoredErrors(),
SuppressStatements: conf.IgnoredLogs(),
}
logger = loggers.New(logOpts)
}
Expand Down
4 changes: 2 additions & 2 deletions tpl/data/data.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (ns *Namespace) GetCSV(sep string, args ...any) (d [][]string, err error) {
if security.IsAccessDenied(err) {
return nil, err
}
ns.deps.Log.Errorsf(constants.ErrRemoteGetCSV, "Failed to get CSV resource %q: %s", url, err)
ns.deps.Log.Erroridf(constants.ErrRemoteGetCSV, "Failed to get CSV resource %q: %s", url, err)
return nil, nil
}

Expand Down Expand Up @@ -132,7 +132,7 @@ func (ns *Namespace) GetJSON(args ...any) (any, error) {
if security.IsAccessDenied(err) {
return nil, err
}
ns.deps.Log.Errorsf(constants.ErrRemoteGetJSON, "Failed to get JSON resource %q: %s", url, err)
ns.deps.Log.Erroridf(constants.ErrRemoteGetJSON, "Failed to get JSON resource %q: %s", url, err)
return nil, nil
}

Expand Down
12 changes: 9 additions & 3 deletions tpl/fmt/fmt.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ func (ns *Namespace) Errorf(format string, args ...any) string {
// an information text that the error with the given id can be suppressed in config.
// It returns an empty string.
func (ns *Namespace) Erroridf(id, format string, args ...any) string {
format += "\nYou can suppress this error by adding the following to your site configuration:\nignoreErrors = ['%s']"
args = append(args, id)
ns.logger.Errorsf(id, format, args...)
ns.logger.Erroridf(id, format, args...)
return ""
}

Expand All @@ -81,6 +79,14 @@ func (ns *Namespace) Warnf(format string, args ...any) string {
return ""
}

// Warnidf formats args according to a format specifier and logs an WARNING and
// an information text that the warning with the given id can be suppressed in config.
// It returns an empty string.
func (ns *Namespace) Warnidf(id, format string, args ...any) string {
ns.logger.Warnidf(id, format, args...)
return ""
}

// Warnmf is epxermimental and subject to change at any time.
func (ns *Namespace) Warnmf(m any, format string, args ...any) string {
return ns.logmf(ns.logger.Warn(), m, format, args...)
Expand Down
29 changes: 21 additions & 8 deletions tpl/fmt/fmt_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package fmt_test
import (
"testing"

qt "github.com/frankban/quicktest"
"github.com/gohugoio/hugo/hugolib"
)

Expand All @@ -32,13 +33,25 @@ ignoreErrors = ['error-b']
{{ erroridf "error-b" "%s" "b"}}
`

b := hugolib.NewIntegrationTestBuilder(
hugolib.IntegrationTestConfig{
T: t,
TxtarString: files,
},
)
b, err := hugolib.TestE(t, files)

b.BuildE()
b.AssertLogMatches(`^ERROR a\nYou can suppress this error by adding the following to your site configuration:\nignoreErrors = \['error-a'\]\n$`)
b.Assert(err, qt.IsNotNil)
b.AssertLogMatches(`^ERROR a\nYou can suppress this error by adding the following to your site configuration:\nignoreLogs = \['error-a'\]\n$`)
}

func TestWarnidf(t *testing.T) {
t.Parallel()

files := `
-- hugo.toml --
disableKinds = ['page','rss','section','sitemap','taxonomy','term']
ignoreLogs = ['warning-b']
-- layouts/index.html --
{{ warnidf "warning-a" "%s" "a"}}
{{ warnidf "warning-b" "%s" "b"}}
`

b := hugolib.Test(t, files, hugolib.TestOptWarn())
b.AssertLogContains("WARN a", "You can suppress this warning", "ignoreLogs", "['warning-a']")
b.AssertLogNotContains("['warning-b']")
}
7 changes: 7 additions & 0 deletions tpl/fmt/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ func init() {
},
)

ns.AddMethodMapping(ctx.Warnidf,
[]string{"warnidf"},
[][2]string{
{`{{ warnidf "my-warn-id" "%s." "warning" }}`, ``},
},
)

ns.AddMethodMapping(ctx.Warnf,
[]string{"warnf"},
[][2]string{
Expand Down

0 comments on commit 098a0ce

Please sign in to comment.