Fix list pagination #240
Closed
Fix list pagination #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pagination to pagelayout partial using pagination_data. Add pagination_data list layout to allow list pagination Fixes: gohugoio/hugoDocs#1547
thewheat
commented
Oct 2, 2022
| @@ -27,6 +27,10 @@ <h1 class="primary-color-dark f2"> | |||
| </section> | |||
| </div> | |||
|
|
|||
| <div class="nested-list-reset nested-links"> | |||
| {{/* pagination.html: https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/template_embedded.go#L117 */}} | |||
| {{ template "_internal/pagination.html" .pagination_data }} | |||
There was a problem hiding this comment.
- I initially tried using
.contextbut it did not work with the following error
failed to render pages: render of "page" failed: execute of template failed at <partial "pagelayout.html" (dict "context" . "section_to_display" $section_to_display)>: error calling partial: execute of template failed at <$page.Paginator.TotalPages>: error calling TotalPages: runtime error: invalid memory address or nil pointer dereference
- Am not too familiar with the inner workings thus added a separate key to the
dictand it worked
So if there is a cleaner way do let me know and will be happy to change and confirm how it goes
|
Superseded by gohugoio/hugoDocs#2296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pagination to pagelayout partial using pagination_data. Add pagination_data in list layout to allow list pagination
Fixes: gohugoio/hugoDocs#1547
Preview of change