Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer dereference when failed to scan out the quota records from redis #21046

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

microyahoo
Copy link
Contributor

@microyahoo microyahoo commented Oct 15, 2024

Signed-off-by: Liang Zheng [email protected]

Comprehensive Summary of your change

Issue being fixed

Fixes 21045

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.08%. Comparing base (c8c11b4) to head (47c0278).
Report is 296 commits behind head on main.

Files with missing lines Patch % Lines
src/controller/quota/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21046       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.71%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114603   +101270     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75733    +69684     
- Misses       6983    34727    +27744     
- Partials      301     4143     +3842     
Flag Coverage Δ
unittests 66.08% <0.00%> (+20.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/quota/controller.go 31.66% <0.00%> (ø)

... and 1287 files with indirect coverage changes

@microyahoo microyahoo changed the title fix: nil pointer dereference when failed to scan out the quota record… fix: nil pointer dereference when failed to scan out the quota records from redis Oct 15, 2024
@chlins chlins added the release-note/update Update or Fix label Oct 15, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit de6c96b into goharbor:main Oct 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: nil pointer dereference when failed to scan out the quota records from redis
5 participants