Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: p2p instance test connection #20968

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Sep 26, 2024

Fix internal server error when test connection to p2p instance with credential.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.17%. Comparing base (c8c11b4) to head (08f1254).
Report is 285 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20968       +/-   ##
===========================================
+ Coverage   45.36%   66.17%   +20.80%     
===========================================
  Files         244     1048      +804     
  Lines       13333   114471   +101138     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75751    +69702     
- Misses       6983    34577    +27594     
- Partials      301     4143     +3842     
Flag Coverage Δ
unittests 66.17% <100.00%> (+20.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/p2p/preheat/provider/client/http_client.go 68.61% <100.00%> (ø)
src/pkg/p2p/preheat/provider/dragonfly.go 63.63% <100.00%> (ø)
src/server/v2.0/handler/preheat.go 20.45% <100.00%> (ø)

... and 1284 files with indirect coverage changes

@chlins chlins force-pushed the fix/p2p-instance-test-connection branch from 17a2505 to 5c09e45 Compare September 27, 2024 01:40
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) September 27, 2024 05:04
@stonezdj stonezdj merged commit ad8c5df into goharbor:main Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants