-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the ui bug of banner coming over the search result container #20871
Conversation
@AllForNothing Sorry I have to close the previous PR because some necessary files were merged into a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@kunal-511 Thanks for your contribution. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20871 +/- ##
===========================================
+ Coverage 45.36% 66.26% +20.89%
===========================================
Files 244 1047 +803
Lines 13333 114254 +100921
Branches 2719 2847 +128
===========================================
+ Hits 6049 75711 +69662
- Misses 6983 34415 +27432
- Partials 301 4128 +3827
Flags with carried forward coverage won't be shown. Click here to find out more. |
@MinerYang Please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: kunal-511 <[email protected]>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Bug Report: The banner message was obscuring the search bar issue - #20608
Resolution: The issue has been resolved by adjusting some styles and adding function to ensure the below content does not overlap the search bar.
Details: After applying the style changes, the search bar is now fully visible even with the banner message displayed at the top of the page.
Issue being fixed
Fixes #20608
Please indicate you've done the following: