Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the ui bug of banner coming over the search result container #20871

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Aug 22, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Bug Report: The banner message was obscuring the search bar issue - #20608
Resolution: The issue has been resolved by adjusting some styles and adding function to ensure the below content does not overlap the search bar.
Details: After applying the style changes, the search bar is now fully visible even with the banner message displayed at the top of the page.

Issue being fixed

Fixes #20608

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@kunal-511
Copy link
Contributor Author

@AllForNothing Sorry I have to close the previous PR because some necessary files were merged into a commit.
Please review this one

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing
Copy link
Contributor

@kunal-511 Thanks for your contribution.
@wy65701436 need another approval to get this PR merged

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (c8c11b4) to head (b08cc49).
Report is 266 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20871       +/-   ##
===========================================
+ Coverage   45.36%   66.26%   +20.89%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114254   +100921     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    75711    +69662     
- Misses       6983    34415    +27432     
- Partials      301     4128     +3827     
Flag Coverage Δ
unittests 66.26% <ø> (+20.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

@kunal-511
Copy link
Contributor Author

@MinerYang Please review this PR.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 146443e into goharbor:main Aug 28, 2024
12 checks passed
@kunal-511 kunal-511 deleted the ui-bug-#20608 branch August 28, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] The banner message is causing the search bar to be obscured.
6 participants