-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #20658 docker-compose version
is obsolete warning
#20659
Conversation
I don't think I have the permission to label this PR. or maybe there is robot can help me to do so? It's not mentioned in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20659 +/- ##
==========================================
+ Coverage 45.36% 46.30% +0.93%
==========================================
Files 244 247 +3
Lines 13333 13779 +446
Branches 2719 2845 +126
==========================================
+ Hits 6049 6380 +331
- Misses 6983 7069 +86
- Partials 301 330 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
Please confirm it work with legacy docker-compose version , |
Can I check what's the minimun version we need to support? |
Signed-off-by: 蝦米 <[email protected]>
We need at least:
|
I did a test for docker compose without version line on Rocky Linux 8 with docker engine v20.10.10 and docker compose v2, and everything looks good. env:
BTW, docker CE 20.10 is EOL half year ago, I think we may increase the min supported to v23.0 (see https://endoflife.date/docker-engine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…rbor#20659) fix `version` is obsolete warning Signed-off-by: 蝦米 <[email protected]> Co-authored-by: Wang Yan <[email protected]> Co-authored-by: MinerYang <[email protected]> Signed-off-by: kunal-511 <[email protected]>
Comprehensive Summary of your change
This is PR removed the obsoleted global level
version
from the docker compose template.Issue being fixed
Fixes #20658
Please indicate you've done the following: