Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20658 docker-compose version is obsolete warning #20659

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

jhdxr
Copy link
Contributor

@jhdxr jhdxr commented Jun 25, 2024

Comprehensive Summary of your change

This is PR removed the obsoleted global level version from the docker compose template.

Issue being fixed

Fixes #20658

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@jhdxr jhdxr requested a review from a team as a code owner June 25, 2024 07:30
@jhdxr
Copy link
Contributor Author

jhdxr commented Jun 25, 2024

I don't think I have the permission to label this PR. or maybe there is robot can help me to do so? It's not mentioned in the CONTRIBUTING.md

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (c8c11b4) to head (2e107f1).
Report is 256 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20659      +/-   ##
==========================================
+ Coverage   45.36%   46.30%   +0.93%     
==========================================
  Files         244      247       +3     
  Lines       13333    13779     +446     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6380     +331     
- Misses       6983     7069      +86     
- Partials      301      330      +29     
Flag Coverage Δ
unittests 46.30% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@MinerYang
Copy link
Contributor

Please confirm it work with legacy docker-compose version ,
Thx~

@jhdxr
Copy link
Contributor Author

jhdxr commented Jul 1, 2024

Please confirm it work with legacy docker-compose version , Thx~

Can I check what's the minimun version we need to support?

@MinerYang
Copy link
Contributor

MinerYang commented Jul 5, 2024

Please confirm it work with legacy docker-compose version , Thx~

Can I check what's the minimun version we need to support?

We need at least:

  • docker-compose (v1.18.0+) or docker compose v2 (docker-compose-plugin)
  • docker engine Version 20.10.10-ce+ or higher

@jhdxr
Copy link
Contributor Author

jhdxr commented Aug 2, 2024

Please confirm it work with legacy docker-compose version , Thx~

Can I check what's the minimun version we need to support?

We need at least:

* docker-compose (v1.18.0+) or docker compose v2 (docker-compose-plugin)

* docker engine Version 20.10.10-ce+ or higher

I did a test for docker compose without version line on Rocky Linux 8 with docker engine v20.10.10 and docker compose v2, and everything looks good.

env:

NAME="Rocky Linux"
VERSION="8.9 (Green Obsidian)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.9"

Server: Docker Engine - Community
 Engine:
  Version:          20.10.10
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.16.9
  Git commit:       e2f740d
  Built:            Mon Oct 25 07:41:17 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.32
  GitCommit:        8b3b7ca2e5ce38e8f31a34f35b2b68ceb8470d89
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Docker Compose version v2.27.0

BTW, docker CE 20.10 is EOL half year ago, I think we may increase the min supported to v23.0 (see https://endoflife.date/docker-engine)

@wy65701436 wy65701436 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Aug 8, 2024
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jhdxr, Thanks for your contribution to Harbor community!

Best,
Miner

@MinerYang MinerYang enabled auto-merge (squash) August 12, 2024 06:20
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit cadd382 into goharbor:main Aug 12, 2024
12 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
…rbor#20659)

fix `version` is obsolete warning

Signed-off-by: 蝦米 <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Co-authored-by: MinerYang <[email protected]>
Signed-off-by: kunal-511 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose: version is obsolete
5 participants