Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls support for pushing sbom #20514

Merged
merged 3 commits into from
May 30, 2024
Merged

tls support for pushing sbom #20514

merged 3 commits into from
May 30, 2024

Conversation

wy65701436
Copy link
Contributor

Make it supports the tls configuration for the client for pushing sbom object

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (b7b8847) to head (b6c45aa).
Report is 203 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20514      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.32%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113478    +4297     
  Branches     2719     2842     +123     
==========================================
+ Hits        73768    75182    +1414     
- Misses      31449    34188    +2739     
- Partials     3964     4108     +144     
Flag Coverage Δ
unittests 66.25% <25.00%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/util.go 57.14% <25.00%> (ø)

... and 573 files with indirect coverage changes

src/pkg/scan/util.go Fixed Show fixed Hide fixed
src/pkg/scan/util.go Outdated Show resolved Hide resolved
Make it supports the tls configuration for the client for pushing sbom object

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 8bc76a6 into goharbor:main May 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants