Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close file #20220

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: close file #20220

merged 1 commit into from
Apr 3, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Apr 3, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <[email protected]>
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (1d2f3d4) to head (19d2e20).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #20220      +/-   ##
==================================================
+ Coverage           67.52%   67.54%   +0.02%     
==================================================
  Files                 991      991              
  Lines              109189   109190       +1     
  Branches             2719     2719              
==================================================
+ Hits                73729    73757      +28     
+ Misses              31492    31471      -21     
+ Partials             3968     3962       -6     
Flag Coverage Δ
unittests 67.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/export/digest_calculator.go 45.45% <100.00%> (+5.45%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit a7f62f3 into goharbor:release-2.10.0 Apr 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants