Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] panic due to mark retention task error #20168

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20129

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner March 26, 2024 05:21
@stonezdj stonezdj changed the title panic due to mark retention task error [cherry-pick] panic due to mark retention task error Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 67.38%. Comparing base (fcc7ae4) to head (11f5120).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #20168      +/-   ##
=================================================
+ Coverage          67.35%   67.38%   +0.02%     
=================================================
  Files                984      984              
  Lines             107094   107102       +8     
  Branches            2671     2671              
=================================================
+ Hits               72134    72169      +35     
+ Misses             31078    31055      -23     
+ Partials            3882     3878       -4     
Flag Coverage Δ
unittests 67.38% <42.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/retention/controller.go 48.26% <0.00%> (+0.62%) ⬆️
src/controller/replication/execution.go 70.65% <0.00%> (+1.24%) ⬆️
src/controller/systemartifact/execution.go 75.28% <0.00%> (+2.45%) ⬆️
src/pkg/task/dao/task.go 64.31% <80.00%> (+0.10%) ⬆️
src/pkg/task/execution.go 65.04% <0.00%> (-2.39%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) March 26, 2024 05:38
@stonezdj stonezdj merged commit 7675eab into goharbor:release-2.8.0 Mar 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants