Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick]Update replication rule filter label xpath #19901

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[cherry-pick]Update replication rule filter label xpath #19901

merged 1 commit into from
Jan 24, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Jan 24, 2024
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 24, 2024 07:44
wy65701436
wy65701436 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit d378663 into goharbor:release-2.9.0 Jan 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@stonezdj stonezdj Awaiting requested review from stonezdj

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@zyyw zyyw

@OrlinVasilev OrlinVasilev

@YangJiao0817 YangJiao0817

Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YangJiao0817 @wy65701436 @zyyw @stonezdj @OrlinVasilev