Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Remove robot account update quota permission #19818

Merged

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 9, 2024 09:20
@YangJiao0817 YangJiao0817 changed the title Remove robot account update quota permission [cherry-pick]Remove robot account update quota permission Jan 9, 2024
@YangJiao0817 YangJiao0817 added the release-note/update Update or Fix label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f62f04b) 67.55% compared to head (182b9cd) 67.55%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2.10.0   #19818   +/-   ##
===============================================
  Coverage           67.55%   67.55%           
===============================================
  Files                 991      991           
  Lines              109175   109175           
  Branches             2719     2719           
===============================================
  Hits                73748    73748           
  Misses              31458    31458           
  Partials             3969     3969           
Flag Coverage Δ
unittests 67.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) January 10, 2024 02:34
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 241b417 into goharbor:release-2.10.0 Jan 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants