Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix system label resource #19621

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix system label resource #19621

merged 1 commit into from
Nov 27, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Nov 27, 2023

Make sure robot can use rbac.Resource(label) to access system level label

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Make sure robot can use rbac.Resource(label) to access system level label

Signed-off-by: wang yan <[email protected]>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #19621 (318ff18) into main (45b41d4) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19621      +/-   ##
==========================================
- Coverage   67.52%   67.51%   -0.02%     
==========================================
  Files         991      991              
  Lines      109168   109167       -1     
  Branches     2719     2719              
==========================================
- Hits        73721    73707      -14     
- Misses      31476    31488      +12     
- Partials     3971     3972       +1     
Flag Coverage Δ
unittests 67.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/label.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit e690030 into goharbor:main Nov 27, 2023
11 of 16 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Make sure robot can use rbac.Resource(label) to access system level label

Signed-off-by: wang yan <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants