-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the permission scope #19603
Merged
Merged
Update the permission scope #19603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19603 +/- ##
==========================================
- Coverage 45.38% 45.35% -0.04%
==========================================
Files 244 244
Lines 13323 13325 +2
Branches 2719 2719
==========================================
- Hits 6047 6043 -4
- Misses 6974 6979 +5
- Partials 302 303 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
AllForNothing
force-pushed
the
permission-scope
branch
2 times, most recently
from
November 22, 2023 05:27
fe56b44
to
0a1c776
Compare
YangJiao0817
approved these changes
Nov 22, 2023
1. Update the permission scope 2. Sort the resources and actions by unicode Signed-off-by: AllForNothing <[email protected]>
AllForNothing
force-pushed
the
permission-scope
branch
from
November 22, 2023 06:00
0a1c776
to
61dd72c
Compare
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
1. Update the permission scope 2. Sort the resources and actions by unicode Signed-off-by: AllForNothing <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: