Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the permission scope #19603

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 22, 2023

  1. Update the permission scope
  2. Sort the resources and actions by unicode

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #19603 (61dd72c) into main (9875965) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19603      +/-   ##
==========================================
- Coverage   45.38%   45.35%   -0.04%     
==========================================
  Files         244      244              
  Lines       13323    13325       +2     
  Branches     2719     2719              
==========================================
- Hits         6047     6043       -4     
- Misses       6974     6979       +5     
- Partials      302      303       +1     
Flag Coverage Δ
unittests 45.35% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...issions-panel/robot-permissions-panel.component.ts 63.79% <100.00%> (+1.29%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing force-pushed the permission-scope branch 2 times, most recently from fe56b44 to 0a1c776 Compare November 22, 2023 05:27
1. Update the permission scope
2. Sort the resources and actions by unicode

Signed-off-by: AllForNothing <[email protected]>
@wy65701436 wy65701436 merged commit d967ac0 into goharbor:main Nov 22, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Update the permission scope
2. Sort the resources and actions by unicode

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants