Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show OIDC provider name on the OIDC login button #19581

Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 15, 2023

  1. Related issue Customize the text of the OIDC login button #13198
Screenshot 2023-11-15 at 12 46 02

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner November 15, 2023 04:46
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 15, 2023
@AllForNothing AllForNothing enabled auto-merge (squash) November 15, 2023 04:48
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #19581 (903fd48) into main (3f6c029) will decrease coverage by 22.27%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19581       +/-   ##
===========================================
- Coverage   67.54%   45.27%   -22.27%     
===========================================
  Files         990      244      -746     
  Lines      109055    13320    -95735     
  Branches     2719     2720        +1     
===========================================
- Hits        73659     6031    -67628     
+ Misses      31429     6989    -24440     
+ Partials     3967      300     -3667     
Flag Coverage Δ
unittests 45.27% <50.00%> (-22.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/portal/src/app/services/app-config.ts 100.00% <100.00%> (ø)
...ortal/src/app/account/sign-in/sign-in.component.ts 53.33% <0.00%> (-0.52%) ⬇️

... and 748 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 6a6e295 into goharbor:main Nov 15, 2023
11 of 14 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Related issue goharbor#13198

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants