Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow POST method to request service/token in readonly mode #19556

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 9, 2023

fixes #18243

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #19556 (c5d0f82) into main (f6d5bf2) will decrease coverage by 22.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19556       +/-   ##
===========================================
- Coverage   67.53%   45.30%   -22.23%     
===========================================
  Files         990      244      -746     
  Lines      109021    13318    -95703     
  Branches     2719     2719               
===========================================
- Hits        73629     6034    -67595     
+ Misses      31426     6983    -24443     
+ Partials     3966      301     -3665     
Flag Coverage Δ
unittests 45.30% <ø> (-22.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

@stonezdj stonezdj assigned zyyw and chlins and unassigned Vad1mo, OrlinVasilev and MinerYang Nov 9, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23nov09_post_token_service branch 3 times, most recently from e461b87 to 01b2030 Compare November 10, 2023 03:40
@stonezdj stonezdj enabled auto-merge (squash) November 10, 2023 03:41
@stonezdj stonezdj merged commit 3a9d68a into goharbor:main Nov 10, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for POST /service/token in readonly mode
7 participants