Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting quota #19538

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: sorting quota #19538

merged 1 commit into from
Nov 13, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Nov 6, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16517

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #19538 (9dd8635) into main (219e4ba) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19538      +/-   ##
==========================================
+ Coverage   45.21%   45.26%   +0.04%     
==========================================
  Files         244      244              
  Lines       13318    13318              
  Branches     2719     2719              
==========================================
+ Hits         6022     6028       +6     
+ Misses       6995     6988       -7     
- Partials      301      302       +1     
Flag Coverage Δ
unittests 45.26% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@zyyw zyyw force-pushed the sort-quota branch 3 times, most recently from 707b822 to dcb05d0 Compare November 7, 2023 11:25
@zyyw zyyw changed the title fix: sorting quota [WIP] fix: sorting quota Nov 9, 2023
@zyyw zyyw force-pushed the sort-quota branch 2 times, most recently from edde44d to 645739a Compare November 9, 2023 10:55
@zyyw zyyw changed the title [WIP] fix: sorting quota fix: sorting quota Nov 9, 2023
Signed-off-by: Shengwen Yu <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit e941f32 into goharbor:main Nov 13, 2023
12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
fix: sort Project Quotas

Signed-off-by: Shengwen Yu <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects can not be sorted by consumed quota in "Project Quotas"
5 participants