Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add banner message API test case #19514

Conversation

YangJiao0817
Copy link
Member

Fix #19271

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #19514 (0edc541) into release-2.9.0 (6d81772) will decrease coverage by 22.56%.
Report is 1 commits behind head on release-2.9.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #19514       +/-   ##
==================================================
- Coverage          67.40%   44.85%   -22.56%     
==================================================
  Files                993      244      -749     
  Lines             108932    13416    -95516     
  Branches            2752     2752               
==================================================
- Hits               73430     6018    -67412     
+ Misses             31549     7092    -24457     
+ Partials            3953      306     -3647     
Flag Coverage Δ
unittests 44.85% <ø> (-22.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 31, 2023 08:22
@YangJiao0817 YangJiao0817 merged commit f2cfc97 into goharbor:release-2.9.0 Oct 31, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants