Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add GC accessory API test case #19463

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Oct 18, 2023

Fix #19273

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Oct 18, 2023
@YangJiao0817 YangJiao0817 self-assigned this Oct 18, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner October 18, 2023 02:52
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #19463 (b851de9) into release-2.9.0 (4ca48d9) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19463      +/-   ##
=================================================
- Coverage          67.41%   67.39%   -0.03%     
=================================================
  Files                993      993              
  Lines             108921   108921              
  Branches            2752     2752              
=================================================
- Hits               73430    73403      -27     
- Misses             31541    31572      +31     
+ Partials            3950     3946       -4     
Flag Coverage Δ
unittests 67.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@YangJiao0817 YangJiao0817 force-pushed the add-gc-accessory-api-testcase-2.9 branch from 2b4dad2 to b851de9 Compare October 18, 2023 04:02
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 18, 2023 06:48
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 86c8dc5 into goharbor:release-2.9.0 Oct 20, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants