Add label's description as tooltip #19421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vad1mo
approved these changes
Oct 8, 2023
Vad1mo
added
release-note/update
Codecov Report
@@ Coverage Diff @@
## main #19421 +/- ##
==========================================
- Coverage 44.89% 44.83% -0.07%
==========================================
Files 244 244
Lines 13416 13417 +1
Branches 2752 2752
==========================================
- Hits 6023 6015 -8
- Misses 7089 7097 +8
- Partials 304 305 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/portal/src/app/shared/components/label/label-piece/label-piece.component.html
Outdated
Show resolved
Hide resolved
|
@Nhqml We use the "eslint" for the UI code format. So you need to run |
auto-merge was automatically disabled
October 23, 2023 18:37
Head branch was pushed to by a user without write access
Will only display the tooltip on artifact-list-page. Signed-off-by: Kenji Gaillac <[email protected]>
Signed-off-by: Kenji Gaillac <[email protected]>
AllForNothing
force-pushed
the
labels-tooltip
branch
from
74cce9b
to
bef4652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Adds a tooltip showing the label's description on artifact-list-page. I believe it is not relevant to show it anywhere else (and from what I've tried it often result in broken UI).
Please find a video of how it looks: https://github.com/goharbor/harbor/assets/48765390/54669aaa-6324-4669-9967-80727fb49e64
Note that I'm a complete noob with Frontend/JS/Angular, therefore please let me know if you believe there is a more elegant way to do this.
Please indicate you've done the following: