Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Remove job status track information from redis after stop the job in the queue #19305

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Sep 5, 2023

After stop in the queue:
Remove key in {harbor_job_service_namespace}:job_track:inprogress
Remove {harbor_job_service_namespace}:job_stats:<job_id>
fixes #19211

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…the queue

  After stop in the queue:
  Remove key in {harbor_job_service_namespace}:job_track:inprogress
  Remove {harbor_job_service_namespace}:job_stats:<job_id>
  fixes goharbor#19211

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj requested a review from a team as a code owner September 5, 2023 01:59
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #19305 (d91368d) into release-2.8.0 (206c5b8) will decrease coverage by 3.18%.
The diff coverage is 52.38%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19305      +/-   ##
=================================================
- Coverage          70.53%   67.35%   -3.18%     
=================================================
  Files                749      984     +235     
  Lines              93978   107090   +13112     
  Branches               0     2671    +2671     
=================================================
+ Hits               66284    72132    +5848     
- Misses             24107    31076    +6969     
- Partials            3587     3882     +295     
Flag Coverage Δ
unittests 67.35% <52.38%> (-3.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/jobmonitor/redis.go 17.58% <52.38%> (+17.58%) ⬆️

... and 242 files with indirect coverage changes

@stonezdj stonezdj changed the title Remove job status track information from redis after stop the job in … (cherry-pick) Remove job status track information from redis after stop the job in … Sep 5, 2023
@stonezdj stonezdj changed the title (cherry-pick) Remove job status track information from redis after stop the job in … (cherry-pick) Remove job status track information from redis after stop the job in the queue Sep 5, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit dd959fb into goharbor:release-2.8.0 Sep 5, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants