Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the max length for the filters #19194

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 16, 2023

1.Fixes #19193

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing added the release-note/update Update or Fix label Aug 16, 2023
AllForNothing pushed a commit to AllForNothing/harbor that referenced this pull request Aug 16, 2023
1.Cherry-pick goharbor#19194

Signed-off-by: AllForNothing <[email protected]>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #19194 (b0cb7a0) into main (56f6c27) will increase coverage by 22.59%.
The diff coverage is 0.00%.

❗ Current head b0cb7a0 differs from pull request most recent head 476fa38. Consider uploading reports for the commit 476fa38 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19194       +/-   ##
===========================================
+ Coverage   44.82%   67.41%   +22.59%     
===========================================
  Files         244      993      +749     
  Lines       13412   108864    +95452     
  Branches     2751     2751               
===========================================
+ Hits         6012    73392    +67380     
- Misses       7095    31529    +24434     
- Partials      305     3943     +3638     
Flag Coverage Δ
unittests 67.41% <0.00%> (+22.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...erability-filter/vulnerability-filter.component.ts 25.00% <0.00%> (ø)

... and 752 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 0e9fe03 into goharbor:main Aug 16, 2023
12 of 13 checks passed
AllForNothing added a commit that referenced this pull request Aug 16, 2023
Update the max length for the filters
1.Cherry-pick #19194

Signed-off-by: AllForNothing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Hub cannot set all search conditions
6 participants