fix: add storage_limit check #19095
Merged
fix: add storage_limit check #19095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19095 +/- ##
=======================================
Coverage 67.39% 67.40%
=======================================
Files 992 993 +1
Lines 108791 108812 +21
Branches 2751 2751
=======================================
+ Hits 73325 73345 +20
+ Misses 31528 31525 -3
- Partials 3938 3942 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
reviewed
Aug 4, 2023
wy65701436
reviewed
Aug 4, 2023
| strVal := utils.GetStrValueOfAnyType(value) | ||
|
|
||
| // check storage per project before setting it | ||
| if key == common.StoragePerProject { |
There was a problem hiding this comment.
why put the specific checking at here?
There was a problem hiding this comment.
Because the check is only for common.StoragePerProject
stonezdj
approved these changes
Aug 7, 2023
stonezdj
reviewed
Aug 7, 2023
src/pkg/config/manager.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("cannot parse string value(%v) to int64", strVal) | ||
| } | ||
| if storagePerProject <= 0 { |
There was a problem hiding this comment.
Because same code appear twice, suggest to extract to function
There was a problem hiding this comment.
thanks for the review. It has been refactored.
…hod to validate quota limit value) Signed-off-by: Shengwen Yu <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18091
task item: 1
Please indicate you've done the following: