fix: escape the event data for slack webhook payload #18424
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18424 +/- ##
==========================================
- Coverage 67.40% 67.37% -0.04%
==========================================
Files 982 982
Lines 106836 106842 +6
Branches 2670 2670
==========================================
- Hits 72016 71986 -30
- Misses 30950 30983 +33
- Partials 3870 3873 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| { | ||
| name: `escape \\"`, | ||
| args: args{str: `{\"foo\":\"bar\"}`}, | ||
| want: `{\\\"foo\\\":\\\"bar\\\"}`, | ||
| }, |
There was a problem hiding this comment.
according to the args & want, it seems that the code is escaping \", instead of \\". Could you please elaborate it? Thanks
There was a problem hiding this comment.
If the input is {\"foo\":\"bar\"}, then escapeEventData function will firstly escape the symbol ", so the input now will look like {\\"foo\\":\\"bar\\"}, but it's not valid because \ also need to be escaped, so escapeEventData function again convert \\" => \\\" to escape the \.
There was a problem hiding this comment.
sorry, it seems that I understand it now. {\"foo\":\"bar\"} is replaced to {\\"foo\\":\\"bar\\"} first by
// escape " to \"
str = strings.Replace(str, `"`, `\"`, -1)
and then replaced to {\\\"foo\\\":\\\"bar\\\"} by
// escape \\" to \\\"
str = strings.Replace(str, `\\"`, `\\\"`, -1)
chlins
force-pushed
the
fix/tag-retention-webhook
branch
from
77c6313 to
9429d9f
Compare
Escape the event data of slack webhook as original payload is invalid when send to slack. Fixes: goharbor#18423 Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
fix/tag-retention-webhook
branch
from
9429d9f to
5026beb
Compare
Escape the event data of slack webhook as original payload is invalid when send to slack.
Fixes: #18423
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18423
Please indicate you've done the following: