Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade mockery version #18332

Merged
merged 1 commit into from
Mar 11, 2023
Merged

feat: upgrade mockery version #18332

merged 1 commit into from
Mar 11, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Mar 10, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #18332 (2bd4c86) into main (ec7c99c) will decrease coverage by 0.02%.
The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18332      +/-   ##
==========================================
- Coverage   67.50%   67.49%   -0.02%     
==========================================
  Files         970      970              
  Lines      106092   106107      +15     
  Branches     2649     2649              
==========================================
- Hits        71616    71615       -1     
- Misses      30647    30659      +12     
- Partials     3829     3833       +4     
Flag Coverage Δ
unittests 67.49% <4.34%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/mgt/mock_manager.go 6.14% <0.00%> (-0.73%) ⬇️
src/jobservice/period/mock_scheduler.go 45.94% <25.00%> (-4.06%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Shengwen Yu <[email protected]>
@zyyw zyyw merged commit 4efee54 into goharbor:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants