Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JobService Dashboard API test cases #18234

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Feb 16, 2023

Added test cases for the following APIs:

  1. GET /jobservice/pools/{pool_id}/workers Get workers
  2. PUT /jobservice/jobs/{job_id} Stop running jc
  3. PUT /jobservice/queues/{job_type} stop and clean, pause, resume pending jobs in the queue
  4. GET /jobservice/queues list job queues
  5. GET /jobservice/pools Get worker pools
  6. GET /schedules List schedules
  7. GET /schedules/{job_type}/paused Get scheduler paused status

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #17948

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #18234 (1fc0eea) into main (73d8e68) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18234      +/-   ##
==========================================
+ Coverage   44.26%   44.31%   +0.04%     
==========================================
  Files         232      232              
  Lines       12797    12797              
  Branches     2579     2579              
==========================================
+ Hits         5665     5671       +6     
+ Misses       6851     6844       -7     
- Partials      281      282       +1     
Flag Coverage Δ
unittests 44.31% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g-retention-tasks/tag-retention-tasks.component.ts 75.00% <0.00%> (-9.38%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 46.51% <0.00%> (+5.81%) ⬆️
...d/worker-card/donut-chart/donut-chart.component.ts 60.00% <0.00%> (+11.42%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Added test cases for the following APIs:
1. GET /jobservice/pools/{pool_id}/workers Get workers
2. PUT /jobservice/jobs/{job_id} Stop running jc
3. PUT /jobservice/queues/{job_type} stop and clean, pause, resume pending jobs in the queue
4. GET /jobservice/queues list job queues
5. GET /jobservice/pools Get worker pools
6. GET /schedules List schedules
7. GET /schedules/{job_type}/paused Get scheduler paused status

Signed-off-by: Yang Jiao <[email protected]>
@YangJiao0817 YangJiao0817 merged commit 2b82f99 into goharbor:main Feb 17, 2023
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
Added test cases for the following APIs:
1. GET /jobservice/pools/{pool_id}/workers Get workers
2. PUT /jobservice/jobs/{job_id} Stop running jc
3. PUT /jobservice/queues/{job_type} stop and clean, pause, resume pending jobs in the queue
4. GET /jobservice/queues list job queues
5. GET /jobservice/pools Get worker pools
6. GET /schedules List schedules
7. GET /schedules/{job_type}/paused Get scheduler paused status

Signed-off-by: Yang Jiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Job service dashboard API testcase
5 participants