Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next scheduled time for tag retention #18223

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 14, 2023

  1. Add the next scheduled time UI
  2. Update font style
  3. Related issue Add Next scheduled time to tag-retention schedule #17399

Signed-off-by: AllForNothing [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner February 14, 2023 10:57
@AllForNothing AllForNothing self-assigned this Feb 14, 2023
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #18223 (17e2c59) into main (c5640ac) will increase coverage by 22.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18223       +/-   ##
===========================================
+ Coverage   44.25%   67.12%   +22.87%     
===========================================
  Files         232      971      +739     
  Lines       12798   105173    +92375     
  Branches     2579     2580        +1     
===========================================
+ Hits         5664    70600    +64936     
- Misses       6853    30829    +23976     
- Partials      281     3744     +3463     
Flag Coverage Δ
unittests 67.12% <0.00%> (+22.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tag-feature-integration/tag-retention/retention.ts 100.00% <ø> (ø)
...tegration/tag-retention/tag-retention.component.ts 21.52% <0.00%> (-0.20%) ⬇️
...audit-log-purge/history/purge-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
src/pkg/p2p/preheat/provider/driver.go 40.00% <0.00%> (ø)
src/common/rbac/system/namespace.go 35.29% <0.00%> (ø)
...c/pkg/systeminfo/imagestorage/filesystem/driver.go 79.31% <0.00%> (ø)
src/pkg/usergroup/dao/dao.go 42.71% <0.00%> (ø)
src/controller/proxy/controller.go 15.69% <0.00%> (ø)
src/pkg/reg/model/policy.go 38.46% <0.00%> (ø)
src/pkg/permission/types/types.go 100.00% <0.00%> (ø)
... and 734 more

@AllForNothing AllForNothing force-pushed the next-scheduled branch 3 times, most recently from 148f8cd to 19c5008 Compare February 21, 2023 12:20
   1. Add next scheduled time UI
   2. Update font style

Signed-off-by: AllForNothing <[email protected]>
@AllForNothing AllForNothing merged commit a79c0ad into goharbor:main Feb 22, 2023
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
1. Add next scheduled time UI
   2. Update font style

Signed-off-by: AllForNothing <[email protected]>
@AllForNothing AllForNothing deleted the next-scheduled branch March 29, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants