Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate English to Chinese for primary auth mode tooltip #18196

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 9, 2023

Related PR #17627
1.Translate the English text into Chinese for primary auth mode tooltip
Signed-off-by: AllForNothing [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner February 9, 2023 04:47
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #18196 (3ae4616) into main (2f04d4f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18196      +/-   ##
==========================================
- Coverage   66.62%   66.60%   -0.02%     
==========================================
  Files         999      999              
  Lines      108136   108136              
  Branches     2579     2579              
==========================================
- Hits        72046    72029      -17     
- Misses      32130    32144      +14     
- Partials     3960     3963       +3     
Flag Coverage Δ
unittests 66.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/worker-card/donut-chart/donut-chart.component.ts 48.57% <0.00%> (-11.43%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 32.00% <0.00%> (-4.00%) ⬇️
src/common/utils/passports.go 86.27% <0.00%> (-3.93%) ⬇️
...dashboard/schedule-card/schedule-card.component.ts 43.28% <0.00%> (-2.99%) ⬇️
src/controller/event/topic.go 8.45% <0.00%> (-2.12%) ⬇️
src/server/v2.0/handler/user.go 14.79% <0.00%> (-1.54%) ⬇️
src/lib/cache/helper.go 75.00% <0.00%> (ø)
src/controller/event/handler/auditlog/auditlog.go 60.71% <0.00%> (+3.57%) ⬆️
...audit-log-purge/history/purge-history.component.ts 46.51% <0.00%> (+5.81%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit cece65c into goharbor:main Feb 13, 2023
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
@AllForNothing AllForNothing deleted the chinese-translation branch March 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants