-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate English to Chinese for primary auth mode tooltip #18196
Merged
AllForNothing
merged 1 commit into
goharbor:main
from
AllForNothing:chinese-translation
Feb 13, 2023
Merged
Translate English to Chinese for primary auth mode tooltip #18196
AllForNothing
merged 1 commit into
goharbor:main
from
AllForNothing:chinese-translation
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllForNothing
added
the
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
label
Feb 9, 2023
AllForNothing
assigned AllForNothing and unassigned wy65701436, OrlinVasilev and MinerYang
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #18196 +/- ##
==========================================
- Coverage 66.62% 66.60% -0.02%
==========================================
Files 999 999
Lines 108136 108136
Branches 2579 2579
==========================================
- Hits 72046 72029 -17
- Misses 32130 32144 +14
- Partials 3960 3963 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Vad1mo
approved these changes
Feb 10, 2023
wy65701436
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: AllForNothing <[email protected]>
AllForNothing
force-pushed
the
chinese-translation
branch
from
February 13, 2023 03:18
be6f7a8
to
3ae4616
Compare
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
…18196) Signed-off-by: AllForNothing <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
sebglon
pushed a commit
to sebglon/harbor
that referenced
this pull request
Mar 6, 2023
…18196) Signed-off-by: AllForNothing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #17627
1.Translate the English text into Chinese for primary auth mode tooltip
Signed-off-by: AllForNothing [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: