Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Avoid internal error in the UI when reset a schedule #17960

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Dec 8, 2022

fixes #17926

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner December 8, 2022 12:45
@stonezdj stonezdj assigned stonezdj, wy65701436 and chlins and unassigned Vad1mo Dec 8, 2022
@stonezdj stonezdj requested review from wy65701436 and chlins December 8, 2022 12:46
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #17960 (e613146) into release-2.7.0 (a2d0a87) will increase coverage by 22.40%.
The diff coverage is 37.50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.7.0   #17960       +/-   ##
==================================================
+ Coverage          44.00%   66.41%   +22.40%     
==================================================
  Files                245     1012      +767     
  Lines              13383   108593    +95210     
  Branches            2673     2673               
==================================================
+ Hits                5889    72118    +66229     
- Misses              7209    32518    +25309     
- Partials             285     3957     +3672     
Flag Coverage Δ
unittests 66.41% <37.50%> (+22.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/scheduler/scheduler.go 67.22% <28.57%> (ø)
src/pkg/task/execution.go 61.45% <100.00%> (ø)
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (-4.45%) ⬇️
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/pkg/artifact/dao/dao.go 57.34% <0.00%> (ø)
src/jobservice/job/priority.go 100.00% <0.00%> (ø)
src/jobservice/worker/cworker/reaper.go 43.77% <0.00%> (ø)
src/pkg/permission/types/namespace.go 73.91% <0.00%> (ø)
src/server/middleware/security/robot.go 32.43% <0.00%> (ø)
src/pkg/ldap/filter.go 100.00% <0.00%> (ø)
... and 762 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj changed the title Avoid internal error in the UI when reset a schedule (cherry-pick) Avoid internal error in the UI when reset a schedule Dec 9, 2022
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 9d2a7bf into goharbor:release-2.7.0 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants