Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the log information in proxy cache #17936

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Dec 7, 2022

Fixes #17933

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #17936 (488766e) into main (e04c1fd) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17936      +/-   ##
==========================================
- Coverage   44.10%   44.05%   -0.06%     
==========================================
  Files         245      245              
  Lines       13383    13383              
  Branches     2673     2673              
==========================================
- Hits         5903     5896       -7     
- Misses       7194     7200       +6     
- Partials      286      287       +1     
Flag Coverage Δ
unittests 44.05% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g-retention-tasks/tag-retention-tasks.component.ts 75.00% <0.00%> (-9.38%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
...dashboard/schedule-card/schedule-card.component.ts 43.28% <0.00%> (-2.99%) ⬇️
...d/worker-card/donut-chart/donut-chart.component.ts 60.00% <0.00%> (+11.42%) ⬆️

@stonezdj stonezdj force-pushed the 22dec27_fix_inacurate_log_proxy_cache branch 2 times, most recently from 90c11ef to 40d2bf2 Compare December 7, 2022 12:40
@stonezdj stonezdj force-pushed the 22dec27_fix_inacurate_log_proxy_cache branch from 40d2bf2 to 488766e Compare December 7, 2022 13:38
@stonezdj stonezdj requested a review from zyyw December 8, 2022 01:57
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit c4a5843 into goharbor:main Dec 8, 2022
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Dec 12, 2022
tpoxa pushed a commit to container-registry/harbor that referenced this pull request Feb 8, 2023
fixes goharbor#17933

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Maksym <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
fixes goharbor#17933

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for proxy cache
5 participants