Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images #17883

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Nov 28, 2022

Signed-off-by: Yang Jiao [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Yang Jiao <[email protected]>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 added the release-note/ignore-for-release Do not include PR or Issue for release notes label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #17883 (156e4ae) into main (402363d) will increase coverage by 22.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #17883       +/-   ##
===========================================
+ Coverage   44.25%   66.42%   +22.17%     
===========================================
  Files         244     1012      +768     
  Lines       13389   108516    +95127     
  Branches     2678     2678               
===========================================
+ Hits         5925    72081    +66156     
- Misses       7177    32479    +25302     
- Partials      287     3956     +3669     
Flag Coverage Δ
unittests 66.42% <ø> (+22.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/schedule-card/schedule-card.component.ts 45.71% <0.00%> (-2.86%) ⬇️
src/server/middleware/cosign/cosign.go 53.73% <0.00%> (ø)
src/controller/event/handler/util/util.go 75.00% <0.00%> (ø)
src/pkg/retention/policy/action/index/index.go 40.90% <0.00%> (ø)
src/common/registryctl/client.go 0.00% <0.00%> (ø)
src/server/middleware/security/robot.go 32.43% <0.00%> (ø)
src/pkg/p2p/preheat/provider/mock.go 52.57% <0.00%> (ø)
src/pkg/scan/dao/scan/model.go 32.00% <0.00%> (ø)
src/pkg/reg/dao/model.go 100.00% <0.00%> (ø)
src/pkg/repository/manager.go 73.68% <0.00%> (ø)
... and 760 more

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 662cd61 into goharbor:main Nov 29, 2022
tpoxa pushed a commit to container-registry/harbor-next that referenced this pull request Feb 8, 2023
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Maksym <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants