-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove job parameters and schedule extra attribute #17878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonezdj
added
release-note/ignore-for-release
Do not include PR or Issue for release notes
target/2.7.0
labels
Nov 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #17878 +/- ##
==========================================
- Coverage 66.42% 66.41% -0.01%
==========================================
Files 1012 1012
Lines 108550 108516 -34
Branches 2678 2678
==========================================
- Hits 72105 72075 -30
+ Misses 32492 32484 -8
- Partials 3953 3957 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zyyw
approved these changes
Nov 28, 2022
stonezdj
changed the title
Dispaly job parameters
Remove job parameters and schedule extra attribute
Nov 28, 2022
stonezdj
force-pushed
the
22nov27_add_job_args
branch
from
November 28, 2022 05:57
a8d18d4
to
00aee3e
Compare
Remove extra attribute and cron type from schedule fixes goharbor#17866 Signed-off-by: stonezdj <[email protected]>
stonezdj
force-pushed
the
22nov27_add_job_args
branch
from
November 28, 2022 06:44
00aee3e
to
eb9d63d
Compare
tpoxa
pushed a commit
to container-registry/harbor-next
that referenced
this pull request
Feb 8, 2023
Remove job parameters from job Remove extra attribute and cron type from schedule fixes goharbor#17866 Signed-off-by: stonezdj <[email protected]> Signed-off-by: stonezdj <[email protected]> Signed-off-by: Maksym <[email protected]>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
Remove job parameters from job Remove extra attribute and cron type from schedule fixes goharbor#17866 Signed-off-by: stonezdj <[email protected]> Signed-off-by: stonezdj <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17866
Signed-off-by: stonezdj [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: