Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job parameters and schedule extra attribute #17878

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 27, 2022

fixes #17866

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner November 27, 2022 05:12
@stonezdj stonezdj added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.7.0 labels Nov 27, 2022
@stonezdj stonezdj requested review from zyyw and chlins November 27, 2022 05:13
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #17878 (eb9d63d) into main (80999f2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17878      +/-   ##
==========================================
- Coverage   66.42%   66.41%   -0.01%     
==========================================
  Files        1012     1012              
  Lines      108550   108516      -34     
  Branches     2678     2678              
==========================================
- Hits        72105    72075      -30     
+ Misses      32492    32484       -8     
- Partials     3953     3957       +4     
Flag Coverage Δ
unittests 66.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/v2.0/handler/jobservice.go 0.00% <ø> (ø)
src/lib/cache/util.go 73.07% <0.00%> (-15.39%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (-8.89%) ⬇️
src/server/v2.0/restapi/embedded_spec.go 100.00% <0.00%> (ø)
...-job/gc-page/gc/gc-history/gc-history.component.ts 46.51% <0.00%> (+5.81%) ⬆️
...audit-log-purge/history/purge-history.component.ts 46.51% <0.00%> (+5.81%) ⬆️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj changed the title Dispaly job parameters Remove job parameters and schedule extra attribute Nov 28, 2022
@stonezdj stonezdj force-pushed the 22nov27_add_job_args branch from a8d18d4 to 00aee3e Compare November 28, 2022 05:57
  Remove extra attribute and cron type from schedule
  fixes goharbor#17866

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 22nov27_add_job_args branch from 00aee3e to eb9d63d Compare November 28, 2022 06:44
@stonezdj stonezdj merged commit 402363d into goharbor:main Nov 28, 2022
tpoxa pushed a commit to container-registry/harbor-next that referenced this pull request Feb 8, 2023
Remove job parameters from job

  Remove extra attribute and cron type from schedule
  fixes goharbor#17866

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Maksym <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Remove job parameters from job

  Remove extra attribute and cron type from schedule
  fixes goharbor#17866

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job Parameter should not show null
3 participants