Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English text for job service UI #17832

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 22, 2022

  1. Update English text for job service UI according to the UI designer's comments
    Signed-off-by: AllForNothing [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #17832 (f3ed93f) into main (a826720) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17832      +/-   ##
==========================================
- Coverage   66.45%   66.44%   -0.02%     
==========================================
  Files        1012     1012              
  Lines      108433   108433              
  Branches     2677     2677              
==========================================
- Hits        72058    72046      -12     
- Misses      32429    32441      +12     
  Partials     3946     3946              
Flag Coverage Δ
unittests 66.44% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 14.28% <0.00%> (-46.43%) ⬇️
src/controller/event/topic.go 2.11% <0.00%> (-6.34%) ⬇️
src/jobservice/logger/sweeper/file_sweeper.go 56.25% <0.00%> (-6.25%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 32.00% <0.00%> (-4.00%) ⬇️
src/jobservice/sync/schedule.go 56.91% <0.00%> (+3.95%) ⬆️
src/core/api/internal.go 44.82% <0.00%> (+8.62%) ⬆️
...d/worker-card/donut-chart/donut-chart.component.ts 60.00% <0.00%> (+11.42%) ⬆️

@AllForNothing AllForNothing merged commit fcf0e20 into goharbor:main Nov 23, 2022
@AllForNothing AllForNothing deleted the text branch January 6, 2023 04:11
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Signed-off-by: AllForNothing <[email protected]>

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants