Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue related to redhat registry proxy cache #17789

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 12, 2022

fixes #16495

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #17789 (e16a087) into main (39ca918) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17789      +/-   ##
==========================================
- Coverage   66.56%   66.49%   -0.08%     
==========================================
  Files        1000     1003       +3     
  Lines      106956   107932     +976     
  Branches     2609     2589      -20     
==========================================
+ Hits        71196    71769     +573     
- Misses      31841    32224     +383     
- Partials     3919     3939      +20     
Flag Coverage Δ
unittests 66.49% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/proxy/controller.go 15.69% <0.00%> (ø)
src/controller/proxy/manifestcache.go 26.86% <0.00%> (-0.21%) ⬇️
...portal/src/app/shared/directives/port.directive.ts 26.66% <0.00%> (-46.67%) ⬇️
...src/app/shared/services/message-handler.service.ts 18.42% <0.00%> (-13.16%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 22.22% <0.00%> (-11.90%) ⬇️
src/core/auth/authenticator.go 48.81% <0.00%> (-9.45%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 21.71% <0.00%> (-9.05%) ⬇️
...audit-log-purge/history/purge-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
src/pkg/scheduler/dao.go 51.19% <0.00%> (-4.66%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
... and 81 more

@stonezdj stonezdj force-pushed the 22nov11_redhat_registry branch from 35aac67 to e6b3614 Compare November 14, 2022 02:43
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 22nov11_redhat_registry branch from e6b3614 to e16a087 Compare November 18, 2022 06:32
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 4b7d455 into goharbor:main Nov 18, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy cache intermittently fails when using redhat registry
3 participants