Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-assignee for new PRs #17753

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Conversation

OrlinVasilev
Copy link
Member

@OrlinVasilev OrlinVasilev commented Nov 4, 2022

Add new action to auto assign the author of the PR as assignee and 2 of the maintainers as reviewers.
That will help us to improve time to review for PRs!

Signed-off-by: OrlinVasilev [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: OrlinVasilev <[email protected]>
@OrlinVasilev OrlinVasilev added release-note/community release-note/enhancement Label to mark PR to be added under release notes as enhancement release-note/infra Infra related changes e.g. release, test, ship etc... labels Nov 4, 2022
@OrlinVasilev OrlinVasilev requested a review from a team as a code owner November 4, 2022 12:03
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #17753 (99fab7c) into main (4fb0a19) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17753      +/-   ##
==========================================
- Coverage   66.58%   66.53%   -0.05%     
==========================================
  Files         998      997       -1     
  Lines      106908   106721     -187     
  Branches     2597     2589       -8     
==========================================
- Hits        71185    71010     -175     
+ Misses      31806    31789      -17     
- Partials     3917     3922       +5     
Flag Coverage Δ
unittests 66.53% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/cache/util.go 73.07% <0.00%> (-15.39%) ⬇️
...src/app/shared/services/message-handler.service.ts 18.42% <0.00%> (-13.16%) ⬇️
src/core/auth/authenticator.go 48.81% <0.00%> (-9.45%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 21.71% <0.00%> (-9.05%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 22.22% <0.00%> (-8.34%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
src/common/utils/email/mail.go 35.05% <0.00%> (-3.10%) ⬇️
src/server/v2.0/handler/base.go 68.75% <0.00%> (-1.47%) ⬇️
...tegration/immutable-tag/immutable-tag.component.ts 62.50% <0.00%> (-1.36%) ⬇️
src/lib/config/userconfig.go 68.91% <0.00%> (-0.65%) ⬇️
... and 18 more

OrlinVasilev added 3 commits November 11, 2022 13:16
Signed-off-by: OrlinVasilev <[email protected]>
Signed-off-by: OrlinVasilev <[email protected]>
Signed-off-by: OrlinVasilev <[email protected]>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@yanji09 yanji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrlinVasilev OrlinVasilev merged commit ac338a2 into goharbor:main Nov 16, 2022
@OrlinVasilev OrlinVasilev deleted the auto-assignees branch November 16, 2022 08:38
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Co-authored-by: OrlinVasilev <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/community release-note/enhancement Label to mark PR to be added under release notes as enhancement release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants