fix: reduce the high db cpu usage for tag retention #17296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
added
area/performance
area/tag-retention
Codecov Report
@@ Coverage Diff @@
## main #17296 +/- ##
=======================================
Coverage ? 66.97%
=======================================
Files ? 993
Lines ? 83633
Branches ? 2677
=======================================
Hits ? 56011
Misses ? 23742
Partials ? 3880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
reviewed
Aug 3, 2022
chlins
force-pushed
the
fix/tag-retention-high-cpu
branch
3 times, most recently
from
51f21ed
to
ca6ae45
Compare
wy65701436
reviewed
Aug 3, 2022
1. Add two indexes to database migrations. 2. Skip refresh quota in middleware for requests from jobservice. 3. Refresh quota by self in the end of tag retention job. Closes: goharbor#14708 Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
fix/tag-retention-high-cpu
branch
from
ca6ae45
to
2ba3a67
Compare
heww
approved these changes
Aug 3, 2022
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
1. Add two indexes to database migrations. 2. Skip refresh quota in middleware for requests from jobservice. 3. Refresh quota by self in the end of tag retention job. Closes: goharbor#14708 Signed-off-by: chlins <[email protected]>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
1. Add two indexes to database migrations. 2. Skip refresh quota in middleware for requests from jobservice. 3. Refresh quota by self in the end of tag retention job. Closes: goharbor#14708 Signed-off-by: chlins <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14708
Signed-off-by: chlins [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #14708
Please indicate you've done the following: