Return time.Time{} when cron string is empty #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change log level to debug to avoid noise Signed-off-by: stonezdj <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #17289 +/- ##
==========================================
- Coverage 67.09% 67.06% -0.03%
==========================================
Files 993 993
Lines 83548 83600 +52
Branches 2665 2677 +12
==========================================
+ Hits 56053 56064 +11
- Misses 23616 23657 +41
Partials 3879 3879
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
change log level to debug to avoid noise Signed-off-by: stonezdj <[email protected]>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
change log level to debug to avoid noise Signed-off-by: stonezdj <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change log level to debug to avoid noise
Signed-off-by: stonezdj [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: