add parameters for PostgreSQL #16641

sayaoailun · 2022-04-03T12:35:43Z

add conn_max_lifetime and conn_max_idle_time

codecov · 2022-04-12T07:29:45Z

Codecov Report

Merging #16641 (444f6ce) into main (402363d) will increase coverage by 22.18%.
The diff coverage is 71.92%.

@@             Coverage Diff             @@
##             main   #16641       +/-   ##
===========================================
+ Coverage   44.25%   66.43%   +22.18%     
===========================================
  Files         244     1012      +768     
  Lines       13389   108540    +95151     
  Branches     2678     2675        -3     
===========================================
+ Hits         5925    72110    +66185     
- Misses       7177    32475    +25298     
- Partials      287     3955     +3668

Flag	Coverage Δ
unittests	`66.43% <71.92%> (+22.18%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/lib/config/systemconfig.go	`49.27% <0.00%> (ø)`
src/common/dao/pgsql.go	`68.04% <77.77%> (ø)`
src/lib/config/metadata/value.go	`55.26% <83.33%> (ø)`
src/common/dao/base.go	`58.20% <100.00%> (ø)`
src/lib/config/metadata/type.go	`75.60% <100.00%> (ø)`
src/pkg/config/manager.go	`49.13% <100.00%> (ø)`
...d/worker-card/donut-chart/donut-chart.component.ts	`48.57% <0.00%> (-11.43%)`	⬇️
src/server/v2.0/handler/model/jobservice.go	`0.00% <0.00%> (ø)`
src/lib/orm/tx.go	`84.61% <0.00%> (ø)`
src/pkg/reg/adapter/gitlab/client.go	`47.16% <0.00%> (ø)`
... and 767 more

github-actions · 2022-09-29T09:07:33Z

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

sayaoailun · 2022-09-29T09:17:25Z

/remove Stale

wy65701436 · 2022-10-17T06:08:49Z

@chlins we need to validate it before merging.

chlins · 2022-11-15T08:27:41Z

@sayaoailun Hi, please rebase your pr with main branch, thanks!

sayaoailun · 2022-11-29T01:31:56Z

@sayaoailun Hi, please rebase your pr with main branch, thanks!

@chlins Done.

chlins · 2022-11-29T01:36:48Z

@sayaoailun Hi, thanks, but recently we've merged the beego upgrade to the main which may have conflicts and impacts to your pr, so maybe you need to rebase again and then revise the code because beego orm update have some changes in this part.

sayaoailun · 2022-11-29T02:02:26Z

@sayaoailun Hi, thanks, but recently we've merged the beego upgrade to the main which may have conflicts and impacts to your pr, so maybe you need to rebase again and then revise the code because beego orm update have some changes in this part.

@chlins Done.

chlins · 2022-11-29T03:25:38Z

@sayaoailun Thanks your work! I'll merge it after verification.

chlins · 2022-11-29T03:34:16Z

src/common/dao/pgsql.go

@@ -96,6 +100,10 @@ func (p *pgsql) Register(alias ...string) error {
 		return err
 	}

+	db, _ := orm.GetDB(an)
+	db.SetConnMaxLifetime(p.connMaxLifetime)


@sayaoailun Please review the code(line 98), there are some difference after beego upgrade.

@chlins Fixed.

chlins · 2022-11-29T04:19:03Z

src/common/dao/pgsql.go

 		return err
 	}

+	db, _ := orm.GetDB(an)


We'd better check error here to avoid db is nil then will panic in the next line.

@chlins Fixed.

src/cmd/exporter/main.go

src/lib/config/metadata/value.go

src/lib/config/metadata/metadatalist.go

chlins

lgtm

chlins · 2022-11-30T08:58:20Z

@sayaoailun Please check the CI action, the UTTEST failed.

Signed-off-by: sayaoailun <[email protected]>

sayaoailun · 2022-11-30T09:24:33Z

@sayaoailun Please check the CI action, the UTTEST failed.

@chlins Fixed.

Signed-off-by: sayaoailun <[email protected]> Signed-off-by: Maksym <[email protected]>

Signed-off-by: sayaoailun <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>

sayaoailun force-pushed the main branch 2 times, most recently from 322f594 to ef12b04 Compare April 3, 2022 13:21

Vad1mo requested review from stonezdj and heww and removed request for stonezdj April 4, 2022 22:04

MinerYang requested review from Vad1mo and chlins April 18, 2022 09:01

MinerYang assigned wy65701436 and chlins Jul 4, 2022

wy65701436 added release-note/enhancement Label to mark PR to be added under release notes as enhancement candidate/2.7.0 labels Jul 30, 2022

github-actions bot added the Stale label Sep 29, 2022

Vad1mo approved these changes Sep 30, 2022

View reviewed changes

github-actions bot removed the Stale label Sep 30, 2022

wy65701436 added target/2.7.0 and removed candidate/2.7.0 labels Oct 17, 2022

sayaoailun force-pushed the main branch from ef12b04 to 4fc3631 Compare November 16, 2022 00:38

sayaoailun requested a review from a team as a code owner November 16, 2022 00:38

sayaoailun force-pushed the main branch from 4fc3631 to 2fe1b09 Compare November 29, 2022 02:00

chlins reviewed Nov 29, 2022

View reviewed changes

sayaoailun force-pushed the main branch from 2fe1b09 to 79e02d9 Compare November 29, 2022 03:46

chlins reviewed Nov 29, 2022

View reviewed changes

sayaoailun force-pushed the main branch 2 times, most recently from f8d506d to 1561be7 Compare November 29, 2022 06:00

chlins reviewed Nov 30, 2022

View reviewed changes

src/cmd/exporter/main.go Outdated Show resolved Hide resolved

chlins reviewed Nov 30, 2022

View reviewed changes

src/cmd/exporter/main.go Show resolved Hide resolved

sayaoailun force-pushed the main branch from 1561be7 to f495ef9 Compare November 30, 2022 03:47

chlins reviewed Nov 30, 2022

View reviewed changes

src/lib/config/metadata/value.go Show resolved Hide resolved

chlins reviewed Nov 30, 2022

View reviewed changes

src/lib/config/metadata/metadatalist.go Outdated Show resolved Hide resolved

sayaoailun force-pushed the main branch from f495ef9 to bf25c5a Compare November 30, 2022 05:02

chlins approved these changes Nov 30, 2022

View reviewed changes

add parameters for PostgreSQL

444f6ce

Signed-off-by: sayaoailun <[email protected]>

sayaoailun force-pushed the main branch from bf25c5a to 444f6ce Compare November 30, 2022 09:24

chlins merged commit cb11540 into goharbor:main Nov 30, 2022

tpoxa pushed a commit to container-registry/harbor-next that referenced this pull request Feb 8, 2023

add parameters for PostgreSQL (goharbor#16641)

6226f36

Signed-off-by: sayaoailun <[email protected]> Signed-off-by: Maksym <[email protected]>

mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023

add parameters for PostgreSQL (goharbor#16641)

a3c526c

Signed-off-by: sayaoailun <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add parameters for PostgreSQL #16641

add parameters for PostgreSQL #16641

sayaoailun commented Apr 3, 2022

codecov bot commented Apr 12, 2022 •

edited

Loading

github-actions bot commented Sep 29, 2022

sayaoailun commented Sep 29, 2022

wy65701436 commented Oct 17, 2022

chlins commented Nov 15, 2022

sayaoailun commented Nov 29, 2022

chlins commented Nov 29, 2022

sayaoailun commented Nov 29, 2022

chlins commented Nov 29, 2022

chlins Nov 29, 2022

sayaoailun Nov 29, 2022

chlins Nov 29, 2022

sayaoailun Nov 29, 2022

chlins left a comment

chlins commented Nov 30, 2022

sayaoailun commented Nov 30, 2022

add parameters for PostgreSQL #16641

add parameters for PostgreSQL #16641

Conversation

sayaoailun commented Apr 3, 2022

codecov bot commented Apr 12, 2022 • edited Loading

Codecov Report

github-actions bot commented Sep 29, 2022

sayaoailun commented Sep 29, 2022

wy65701436 commented Oct 17, 2022

chlins commented Nov 15, 2022

sayaoailun commented Nov 29, 2022

chlins commented Nov 29, 2022

sayaoailun commented Nov 29, 2022

chlins commented Nov 29, 2022

chlins Nov 29, 2022

Choose a reason for hiding this comment

sayaoailun Nov 29, 2022

Choose a reason for hiding this comment

chlins Nov 29, 2022

Choose a reason for hiding this comment

sayaoailun Nov 29, 2022

Choose a reason for hiding this comment

chlins left a comment

Choose a reason for hiding this comment

chlins commented Nov 30, 2022

sayaoailun commented Nov 30, 2022

codecov bot commented Apr 12, 2022 •

edited

Loading