Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The label should be editable when the replication rule is pull based #15825

Closed
stonezdj opened this issue Oct 20, 2021 · 3 comments · Fixed by #18357
Closed

The label should be editable when the replication rule is pull based #15825

stonezdj opened this issue Oct 20, 2021 · 3 comments · Fixed by #18357
Assignees
@AllForNothing
Labels
area/ui kind/requirement New feature or idea on top of harbor needs/triage triage issue before assigning target/2.8.0

Comments

@stonezdj
Copy link
Contributor

stonezdj commented Oct 20, 2021 •
edited
Loading

The current label filter field is a drop-down selection, but for a pull-based replication, the label is defined in the source Harbor, it might be some label string that is not defined in the current Harbor instance. suggest changing this field to be editable.

Screen Shot 2021-10-20 at 2 35 55 PM

BTW, this feature might make the user consider labels are replicated, but they aren't actually.
@AllForNothing AllForNothing added kind/requirement New feature or idea on top of harbor needs/triage triage issue before assigning labels Oct 20, 2021
@bitsf
Copy link
Contributor

bitsf commented Oct 21, 2021

dup #8207

@bitsf
Copy link
Contributor

bitsf commented Jan 13, 2022

@AllForNothing I think it would be better to make it editable just when user select pull-base replication, you can add a different widget

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 5, 2022
@stonezdj stonezdj removed the Stale label Jul 7, 2022
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Mar 15, 2023
Make label filter editable for replication rule
1c5e605 
1. Fixes goharbor#15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
@AllForNothing AllForNothing mentioned this issue Mar 15, 2023
Merged
5 tasks
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Mar 15, 2023
Make label filter editable for replication rule
ff999b7 
1. Fixes goharbor#15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Mar 15, 2023
Make label filter editable for replication rule
627e2d1 
1. Fixes goharbor#15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Mar 17, 2023
@AllForNothing
Make label filter editable for replication rule
d2517e0 
1. Fixes goharbor#15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this issue Mar 17, 2023
@AllForNothing
Make label filter editable for replication rule
de842e4 
1. Fixes goharbor#15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
AllForNothing added a commit that referenced this issue Mar 17, 2023
@AllForNothing
Make label filter editable for replication rule (#18357)
339f5b1 
1. Fixes #15825
2. Now, you can input labels or select them from the candidates

Signed-off-by: AllForNothing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AllForNothing AllForNothing

Labels
area/ui kind/requirement New feature or idea on top of harbor needs/triage triage issue before assigning target/2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make label filter editable for replication rule AllForNothing/harbor
4 participants
@bitsf @stonezdj @AllForNothing @xaleeks