feat(i18n/gi18n): add key-value translation pattern #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关 还原无关文件
修改多语言替换和参数无关 还原无关文件 处理测试不通过问题
撤销session的变更，只处理多语言
gqcn
requested changes
Oct 8, 2024
i18n/gi18n/gi18n_manager.go
Outdated
| return result | ||
| } | ||
| } | ||
| return fmt.Sprintf(result, values...) |
There was a problem hiding this comment.
实现键值对替换的特性是很不错的，但是这里实现有两点小问题：
- 直接在
TranslateFormat方法中修改违背了这个方法的设计含义，建议提供新方法比如TranslateMap/Tm来实现准确的语义更合适一些。 - 至于键值对替换中对于键的格式如何定义，感觉直接使用
:key的格式有点太宽泛了，使用模板引擎的方式是不是更合适一些(但是又和模板引擎似乎冲突了)，这块看大家有什么建议？
There was a problem hiding this comment.
TranslateFormat 这个方法如果不做处理，翻译后参数位置变了，就不准确了，比如第一个位置的参数，翻译后位置变到第三个了，如果还是按原来的翻译参数顺序就不对了。个人觉得还是要兼容修复下比较好。
There was a problem hiding this comment.
@lxy1151 TranslateFormat的设计就是format中的站位符号和values的顺序是对应的，所以我才说新建一个方法来做不同的事情，设计的逻辑清晰一些。
There was a problem hiding this comment.
新增TranslateMap方法？
我个人建议是这样的，至少在原有方法上改不太合适，大家也可以一起来讨论下。
There was a problem hiding this comment.
已经修改。
增加了TranslateMap方法
增加了Tm快捷方法
gqcn
changed the title
修改多语言替换和参数无关 还原无关文件 处理测试不通过问题 增加了Tm快捷方法 增加了TranslateMap方法
gqcn
requested changes
Nov 11, 2024
| if len(mpStrStr) > 0 { | ||
| for k, v := range mpStrStr { | ||
| rpKey := ":" + k | ||
| result = strings.ReplaceAll(result, rpKey, v) |
There was a problem hiding this comment.
- 我不确定
:key这种模式是否最优雅的替换方式，可以参考其他i18n的转译是使用的什么格式来做的替换。 - 这里直接使用
ReplaceAll似乎也不是很优雅，例如有两个变量:key1和:key2，在替换的时候使用key则会把它们都替换掉了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
多语言翻译：修复翻译语句参数顺序发生变化时，参数值的顺序还是原来的bug。