fix(net/ghttp&gclient,contrib/rpc/grpcx): remove request and response contents in opentelemetry tracing attributes #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contents in opentelemetry tracing attibutes
gqcn
requested review from
houseme,
huangqian1985,
hailaz,
oldme-git and
wln32
gqcn
changed the title
|
有种一刀切的感觉了，直接删除这个内容，但是可以省下不少的成本 |
It feels like one size fits all. Just delete this content, but you can save a lot of costs. |
是的。性能也能提升不少。 |
Yes. Performance can also be improved a lot. |
houseme
approved these changes
Sep 25, 2024
oldme-git
approved these changes
Sep 26, 2024
|
这个也太一刀切了吧？？能否提供自定义的方式？自定义开关或补充到这个属性上？ |
Is this too one-size-fits-all? ? Can you provide a customized method? Customize the switch or add it to this attribute? |
houseme
added a commit
that referenced
this pull request
Sep 28, 2024
…ris-config * 'master' of github.com:gogf/gf: (23 commits) build(go.mod): upgrade minimum required go version from 1.18 to 1.20 (#3688) refactor(net/ghttp): enhance `ghttp.StartPProfServer` (#3555) refactor(encoding/gjson): change data parameter from type any to []byte (#3542) refactor(net/gudp): improve implements (#3491) fix(os/gcache): memory leak for LRU when adding operations more faster than deleting (#3823) fix(os/gcmd): argument index calculating error in multilevel command (#3807) fix(database/gdb): invalid order by statement generated when multiple order inputs (#3803) fix(cmd/gf): creating logic.go empty folder when there is no correct logic service (#3815) test(drivers/mysql): loose unit testing for transaction (#3819) fix(net/ghttp&gclient,contrib/rpc/grpcx): remove request and response contents in opentelemetry tracing attributes (#3810) feat: new version v2.7.4 (#3809) fix(util/gconv): unstable converting when there is an external attribute with the same name as the internal structure (#3799) feat(database/gdb): add year field type support for ORM operations (#3805) fix(cmd/gf): table and field names converted to its lower case before CamelCase converting in command `gen dao` (#3801) fix(net/gclient): panic when containing `@file:` parameter value in json post request (#3775) feat(contrib/registry/etcd/): add `DialTimeout` and `AutoSyncInterval` option (#3698) fix(database/gdb): support OrderRandom feature in different databases (#3794) fix(net/goai): change default value of RequestBody.Required from true to false, add required tag support for RequestBody (#3796) fix(util/gvalid): retrive empty slice parameter in custom validation rule function failed (#3795) fix(util/gconv): cached field indexes append issue caused incorrect field converting (#3790) ... # Conflicts: # .github/workflows/ci-main.sh # .github/workflows/golangci-lint.yml # contrib/metric/otelmetric/go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3791
It is necessary adding request and response content to opentelemetry tracing attributes, which will slow the performance for http & grpc operations.
The main purpose of tracing is to locate the error among services.