Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codes due to static codes analysis #2935

Merged
merged 3 commits into from
Sep 7, 2023
Merged

fix codes due to static codes analysis #2935

merged 3 commits into from
Sep 7, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Sep 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 78.17% and project coverage change: +0.06% 🎉

Comparison is base (74bf1b4) 79.15% compared to head (4a23be0) 79.21%.
Report is 10 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   79.15%   79.21%   +0.06%     
==========================================
  Files         638      639       +1     
  Lines       52570    52732     +162     
==========================================
+ Hits        41611    41772     +161     
- Misses       8892     8895       +3     
+ Partials     2067     2065       -2     
Flag Coverage Δ
go-1.18-386 79.26% <78.17%> (+0.07%) ⬆️
go-1.18-amd64 79.27% <78.17%> (+0.06%) ⬆️
go-1.19-386 79.18% <78.17%> (+0.08%) ⬆️
go-1.19-amd64 79.20% <78.17%> (+0.10%) ⬆️
go-1.20-386 79.27% <78.17%> (+0.04%) ⬆️
go-1.20-amd64 79.30% <78.17%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 98.20% <ø> (ø)
database/gdb/gdb.go 81.49% <ø> (+13.15%) ⬆️
database/gdb/gdb_result.go 36.00% <ø> (+3.85%) ⬆️
internal/instance/instance.go 100.00% <ø> (ø)
net/ghttp/ghttp_request.go 93.23% <ø> (ø)
net/ghttp/ghttp_server_graceful.go 60.45% <ø> (+0.67%) ⬆️
net/ghttp/ghttp_server_router.go 81.25% <0.00%> (-0.27%) ⬇️
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
... and 25 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn changed the title fix: 修复代码中静态检查的警告 fix codes due to static codes analysis Sep 5, 2023
@hailaz hailaz added the done This issue is done, which may be release in next version. label Sep 6, 2023
@hailaz hailaz requested a review from gqcn September 6, 2023 03:55
@gqcn gqcn merged commit 7e16d9b into master Sep 7, 2023
18 checks passed
@gqcn gqcn deleted the fix/staticcheck branch September 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue is done, which may be release in next version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants