Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to v1.61.0 #3135

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Bump golangci-lint to v1.61.0 #3135

merged 2 commits into from
Sep 15, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Sep 15, 2024

Description

  • Bump golangci-lint to v1.61.0

Type of change

  • Code consistency (non-breaking change which improves code reliability and robustness)

@gaby gaby requested a review from a team as a code owner September 15, 2024 12:20
@gaby gaby requested review from sixcolors, ReneWerner87 and efectn and removed request for a team September 15, 2024 12:20
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Walkthrough

The changes involve updates to the version of the golangci-lint tool in both the GitHub Actions workflow and the Makefile. The version has been upgraded from v1.60.3 to v1.61.0 in both instances. Additionally, comments were added and removed in specific source files to clarify the handling of linter warnings. The overall structure and functionality of the workflow, Makefile, and source files remain unchanged.

Changes

File Change Summary
.github/workflows/linter.yml, Makefile Updated golangci-lint tool version from v1.60.3 to v1.61.0 in both the workflow and Makefile.
middleware/cache/cache.go Added comments to clarify intentional ignoring of gosec linter warnings in the New function.
middleware/etag/etag.go Removed unnecessary comment related to the nolint:gosec directive in the New function.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI/CD Pipeline
    participant Linter

    Developer->>CI/CD Pipeline: Push code
    CI/CD Pipeline->>Linter: Run golangci-lint v1.61.0
    Linter-->>CI/CD Pipeline: Return linting results
    CI/CD Pipeline-->>Developer: Provide feedback
Loading

Poem

In the meadow where code does play,
A linter hops in, brightening the day.
With a version so new, it dances with glee,
Catching bugs as it hops, oh so free!
From v1.60 to v1.61,
Our code's now cleaner, the work is done! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc8d944 and fac048d.

Files selected for processing (2)
  • middleware/cache/cache.go (2 hunks)
  • middleware/etag/etag.go (1 hunks)
Files skipped from review due to trivial changes (2)
  • middleware/cache/cache.go
  • middleware/etag/etag.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (62f66e5) to head (fac048d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
+ Coverage   80.11%   80.13%   +0.02%     
==========================================
  Files         117      117              
  Lines        9047     9047              
==========================================
+ Hits         7248     7250       +2     
+ Misses       1364     1363       -1     
+ Partials      435      434       -1     
Flag Coverage Δ
unittests 80.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaby
Copy link
Member Author

gaby commented Sep 15, 2024

Fixing CI in a sec

@ReneWerner87 ReneWerner87 added this to the v3 milestone Sep 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: fac048d Previous: 37f1a65 Ratio
Benchmark_Compress_Levels/Brotli_LevelBestCompression - B/op 6 B/op 0 B/op +∞
Benchmark_Compress_Levels/Zstd_LevelBestCompression - B/op 1 B/op 0 B/op +∞
BenchmarkAppendMsgitem - MB/s 3219.11 MB/s 1823.77 MB/s 1.77
BenchmarkAppendMsgitem - MB/s 2891.82 MB/s 1823.77 MB/s 1.59

This comment was automatically generated by workflow using github-action-benchmark.

@ReneWerner87 ReneWerner87 merged commit 0ef8d71 into main Sep 15, 2024
16 of 17 checks passed
@gaby gaby deleted the golangci-lint-update branch October 5, 2024 11:00
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants