V2 to v3 merge

.github/CONTRIBUTING.md

@@ -15,7 +15,7 @@ Titles always we must use prefix according to below:
 - 📚 Doc: Translate to Portuguese middleware redirect
 - 🎨 Style: Respected pattern Golint
 
-All pull request that contains a feature or fix is mandatory to have unit tests. Your PR is only to be merged if you respect this flow.
+All pull requests that contain a feature or fix are mandatory to have unit tests. Your PR is only to be merged if you respect this flow.
 
 # 👍 Contribute
 

.github/pull_request_template.md

@@ -4,7 +4,7 @@ Please provide a clear and concise description of the changes you've made and th
 
 Related to # (issue)
 
-## Changes Introduced
+## Changes introduced
 
 List the new features or adjustments introduced in this pull request. Provide details on benchmarks, documentation updates, changelog entries, and if applicable, the migration guide.
 
@@ -16,7 +16,7 @@ List the new features or adjustments introduced in this pull request. Provide de
 - [ ] API Longevity: Discuss the steps taken to ensure that the new or updated APIs are consistent and not prone to breaking changes.
 - [ ] Examples: Provide examples demonstrating the new features or changes in action.
 
-## Type of Change
+## Type of change
 
 Please delete options that are not relevant.
 
@@ -39,6 +39,6 @@ Before you submit your pull request, please make sure you meet these requirement
 - [ ] Aimed for optimal performance with minimal allocations in the new code.
 - [ ] Provided benchmarks for the new code to analyze and improve upon.
 
-## Commit Formatting
+## Commit formatting
 
 Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: [CONTRIBUTING.md](https://github.com/gofiber/fiber/blob/master/.github/CONTRIBUTING.md#pull-requests-or-commits)

.golangci.yml

@@ -162,6 +162,12 @@ linters-settings:
 issues:
    exclude-use-default: false
 
+   exclude-rules:
+     # Exclude some linters from running on tests files.
+     - path: _test\.go
+       linters:
+         - bodyclose
+
 linters:
   disable:
     - spancheck # opentelemetry, irrelevant

app.go

@@ -496,7 +496,7 @@ func New(config ...Config) *App {
 	// Create Ctx pool
 	app.pool = sync.Pool{
 		New: func() any {
-			return app.NewCtx(&fasthttp.RequestCtx{})
+			return app.newCtx()
 		},
 	}
 
@@ -1071,9 +1071,7 @@ func (app *App) ErrorHandler(ctx Ctx, err error) error {
 // errors before calling the application's error handler method.
 func (app *App) serverErrorHandler(fctx *fasthttp.RequestCtx, err error) {
 	// Acquire Ctx with fasthttp request from pool
-	c := app.AcquireCtx()
-	c.Reset(fctx)
-
+	c := app.AcquireCtx(fctx)
 	defer app.ReleaseCtx(c)
 
 	var (

app_test.go

@@ -2,7 +2,7 @@
 // 🤖 Github Repository: https://github.com/gofiber/fiber
 // 📌 API Documentation: https://docs.gofiber.io
 
-//nolint:bodyclose, goconst // Much easier to just ignore memory leaks in tests
+//nolint:goconst // Much easier to just ignore memory leaks in tests
 package fiber
 
 import (
@@ -314,7 +314,7 @@ func Test_App_serverErrorHandler_Internal_Error(t *testing.T) {
 	t.Parallel()
 	app := New()
 	msg := "test err"
-	c := app.NewCtx(&fasthttp.RequestCtx{}).(*DefaultCtx) //nolint:errcheck, forcetypeassert // not needed
+	c := app.AcquireCtx(&fasthttp.RequestCtx{}).(*DefaultCtx) //nolint:errcheck, forcetypeassert // not needed
 
 	app.serverErrorHandler(c.fasthttp, errors.New(msg))
 	require.Equal(t, string(c.fasthttp.Response.Body()), msg)
@@ -324,7 +324,7 @@ func Test_App_serverErrorHandler_Internal_Error(t *testing.T) {
 func Test_App_serverErrorHandler_Network_Error(t *testing.T) {
 	t.Parallel()
 	app := New()
-	c := app.NewCtx(&fasthttp.RequestCtx{}).(*DefaultCtx) //nolint:errcheck, forcetypeassert // not needed
+	c := app.AcquireCtx(&fasthttp.RequestCtx{}).(*DefaultCtx) //nolint:errcheck, forcetypeassert // not needed
 
 	app.serverErrorHandler(c.fasthttp, &net.DNSError{
 		Err:       "test error",
@@ -1400,8 +1400,7 @@ func Test_App_Next_Method(t *testing.T) {
 func Benchmark_AcquireCtx(b *testing.B) {
 	app := New()
 	for n := 0; n < b.N; n++ {
-		c := app.AcquireCtx()
-		c.Reset(&fasthttp.RequestCtx{})
+		c := app.AcquireCtx(&fasthttp.RequestCtx{})
 
 		app.ReleaseCtx(c)
 	}
@@ -1612,7 +1611,7 @@ func Test_App_SmallReadBuffer(t *testing.T) {
 
 	go func() {
 		time.Sleep(500 * time.Millisecond)
-		req, err := http.NewRequestWithContext(context.Background(), MethodGet, "http://127.0.0.1:4006/small-read-buffer", http.NoBody)
+		req, err := http.NewRequestWithContext(context.Background(), MethodGet, "http://127.0.0.1:4006/small-read-buffer", nil)
 		require.NoError(t, err)
 		var client http.Client
 		resp, err := client.Do(req)
@@ -1736,7 +1735,7 @@ func Test_App_Test_no_timeout_infinitely(t *testing.T) {
 			return nil
 		})
 
-		req := httptest.NewRequest(MethodGet, "/", http.NoBody)
+		req := httptest.NewRequest(MethodGet, "/", nil)
 		_, err = app.Test(req, -1)
 	}()
 
@@ -1765,7 +1764,7 @@ func Test_App_SetTLSHandler(t *testing.T) {
 	app := New()
 	app.SetTLSHandler(tlsHandler)
 
-	c := app.NewCtx(&fasthttp.RequestCtx{})
+	c := app.AcquireCtx(&fasthttp.RequestCtx{})
 	defer app.ReleaseCtx(c)
 
 	require.Equal(t, "example.golang", c.ClientHelloInfo().ServerName)