Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix remaining testifylint errors #2806

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

nickajacks1
Copy link
Member

If this is too big, I can split this into multiple PRs.

Description

In preparation for the upcoming linter update, fix testifylint errors.
Where possible, require.ErrorContains was avoided. Using require.ErrorContains is planned to eventually be made a lint error.

https://github.com/Antonboom/testifylint

Type of Change

  • Code consistency (non-breaking change which improves code reliability and robustness)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReneWerner87 ReneWerner87 merged commit 3c4509f into gofiber:main Jan 22, 2024
12 checks passed
@nickajacks1 nickajacks1 deleted the lint-testifylint branch February 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants