Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed "Twitter" to "X (Twitter)" in README.md Contribute Section #2696

Merged
merged 24 commits into from
Nov 1, 2023

Conversation

BandhiyaHardik
Copy link
Contributor

Description

in README.md contribute section the name of twitter was old i changed it to 𝕏

Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2695

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

in README.md contribute section the name of twitter was old i changed it to 𝕏
@welcome
Copy link

welcome bot commented Oct 30, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

.github/README.md Outdated Show resolved Hide resolved
updated domain as per suggested
@ReneWerner87
Copy link
Member

@BandhiyaHardik
Copy link
Contributor Author

@ReneWerner87 i will change in it too.

@BandhiyaHardik
Copy link
Contributor Author

@BandhiyaHardik can you also check the other places https://github.com/search?q=repo%3Agofiber%2Ffiber%20com%2Fintent%2Ftweet%3F&type=code

First of all i would like to apology. I didn't changed in other lang.

Thank You for telling me this so in future i do not repeat mistake like this.

i have changed all the files as per instructed.

@BandhiyaHardik
Copy link
Contributor Author

@ReneWerner87 if there are any other changes let me know i will do it

@ReneWerner87 ReneWerner87 merged commit 0104e59 into gofiber:master Nov 1, 2023
1 check passed
Copy link

welcome bot commented Nov 1, 2023

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87 ReneWerner87 added this to the v2 Next Release milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change "Twitter" to "X (Twitter)" in README.md Contribute Section
3 participants