Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor: Remove redundant error check in func QueryParser and BodyParser #2611

Closed
wants to merge 1 commit into from

Conversation

LimJiAn
Copy link
Contributor

@LimJiAn LimJiAn commented Aug 30, 2023

Description

Hello👋
I modified the error scope of the QueryParser function and BodyParser function.
What do you think???

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87
Copy link
Member

pls check the lint warning
code LGTM

Modify the scope of error handling in func QueryParser and BodyParser
@LimJiAn LimJiAn changed the title ♻️ Refactor: Remove redundant error check in func QueryParser ♻️ Refactor: Remove redundant error check in func QueryParser and BodyParser Aug 30, 2023
@LimJiAn
Copy link
Contributor Author

LimJiAn commented Aug 30, 2023

pls check the lint warning code LGTM

I checked. Thank you.
I modified the BodyParser function for the same reason, so could you check it?

@LimJiAn
Copy link
Contributor Author

LimJiAn commented Aug 30, 2023

@ReneWerner87
I pushed the commit by force, so I'd appreciate it if you could check it.

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry made a mistake in the review, after I looked at the adjustment in the body parser

i noticed that these previous conditions at the first error when parsing the body or query parameters should lead to the fact that these are not processed further and then it is terminated with the last error

this is now different

@LimJiAn
Copy link
Contributor Author

LimJiAn commented Aug 30, 2023

sorry made a mistake in the review, after I looked at the adjustment in the body parser

i noticed that these previous conditions at the first error when parsing the body or query parameters should lead to the fact that these are not processed further and then it is terminated with the last error

this is now different

It's hard😭
Thank you for your reply.

@ReneWerner87
Copy link
Member

thanks for your effort

@LimJiAn LimJiAn deleted the refactor_func branch August 31, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants