Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor: Use Global vars instead of local vars for isLocalHost #2595

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

LimJiAn
Copy link
Contributor

@LimJiAn LimJiAn commented Aug 23, 2023

Description

Hello.
How about using global variables instead of local variables?

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87 ReneWerner87 changed the title ♻️ Refactor: Use Global variables instead of local variables ♻️ Refactor: Use Global vars instead of local vars for isLocalHost Aug 23, 2023
@LimJiAn
Copy link
Contributor Author

LimJiAn commented Aug 23, 2023

@ReneWerner87 Thank you! I changed the commit message.

@ReneWerner87 ReneWerner87 merged commit 8ec7cec into gofiber:master Aug 23, 2023
20 checks passed
@LimJiAn LimJiAn deleted the refactor_func branch August 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants