Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fixed validation-guide #2517

Merged
merged 16 commits into from
Jun 27, 2023
Merged

- fixed validation-guide #2517

merged 16 commits into from
Jun 27, 2023

Conversation

Z3NTL3
Copy link
Contributor

@Z3NTL3 Z3NTL3 commented Jun 23, 2023

Description

The old validation guide hosted on the docs was a bit outdated. It was good but, it was only for a single object type validation. Instead with this PR I have changed this. Now the validator can handle any type of object and validate within ease.

I have also made easy examples about how to make custom error message format when a context does not fit our validation scheme.

Type of change

  • Improved validation guide
  • Custom error message format for validator (near choice)
  • A function capable of handling all type of objects data to validate against
  • Improvements towards the debug tests and output showcases
  • Easy showcase about how to make an custom tag format validation

Checklist:

  • I have alot of comments in my code
  • Well formated OUTPUT console to provide a better way of understanding
  • Easy and adaptable code

@welcome
Copy link

welcome bot commented Jun 23, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

docs/guide/validation.md Outdated Show resolved Hide resolved
docs/guide/validation.md Outdated Show resolved Hide resolved
docs/guide/validation.md Outdated Show resolved Hide resolved
Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also check indentions

@Z3NTL3
Copy link
Contributor Author

Z3NTL3 commented Jun 23, 2023

can you also check indentions

fixed it, and yea i though that one of the modules i used already did have that name as package so i simply added _ but i see that i were wrong

@ReneWerner87
Copy link
Member

@Z3NTL3 pls check again the whole code for the in indentions
image
image
image

@Z3NTL3
Copy link
Contributor Author

Z3NTL3 commented Jun 26, 2023

Hello,

I have formatted everything with go fmt, check the commit. All indentations are correct now.

Copy link
Contributor Author

@Z3NTL3 Z3NTL3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated validator pkg import to v10

docs/guide/validation.md Outdated Show resolved Hide resolved
docs/guide/validation.md Outdated Show resolved Hide resolved
@efectn efectn merged commit 80fc222 into gofiber:master Jun 27, 2023
@welcome
Copy link

welcome bot commented Jun 27, 2023

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@Z3NTL3 Z3NTL3 deleted the validation-guide branch June 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants