Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: treat case for possible timer memory leak #2488

Merged
merged 1 commit into from
May 31, 2023

Conversation

luk3skyw4lker
Copy link
Contributor

@luk3skyw4lker luk3skyw4lker commented May 31, 2023

Description

It was reported in the gopsutil a possible memory leak for the Sleep function, the fix is to in case of the timer being cancelled by the context, checking if the timer isn't stopped and stoping it.

Fixes #2482

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@welcome
Copy link

welcome bot commented May 31, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@sixcolors sixcolors requested review from Fenny and sixcolors May 31, 2023 01:47
@gaby gaby requested review from gaby, ReneWerner87 and efectn and removed request for Fenny May 31, 2023 01:57
@gaby
Copy link
Member

gaby commented May 31, 2023

This is an upstream fix from here: shirou/gopsutil#1475

Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaby
Copy link
Member

gaby commented May 31, 2023

Thanks! @luk3skyw4lker

Copy link
Member

@sixcolors sixcolors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReneWerner87 ReneWerner87 merged commit 5d53263 into gofiber:master May 31, 2023
@welcome
Copy link

welcome bot commented May 31, 2023

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@luk3skyw4lker luk3skyw4lker deleted the fix/sleep-memory-leak branch June 2, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Potential leak in sleep.go
5 participants